Adding option to check backend health via TLS #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmoehl
previously approved these changes
Aug 7, 2024
|
As a side-note: for our environments we decided to stick to non-TLS health-checks to reduce the amount of TLS handshakes which need to be performed and save some resources. But it's always good to offer the option for those that want it! |
|
We are at evaluating the impact of TLS checks at the moment. Though generally its probably a good idea to offer it at least, even if most people won't use it right now. As once caveat you either need to resign the health cert for the Gorouter with the router-ca or tell haproxy both router and service_cf_internal_ca. (for whoever comes in 3 years debugging heir ssl error). |
maxmoehl
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello haproxy people,
CF Gorouter wants to switch to TLS healthchecks. I tested out if the HAProxy works with it. I found the issue that unless you tell it explicitly to only use TLS for health checks it will run into TLS issues (namely not using it). THis PR aims to add an option to enable check-ssl (https://docs.haproxy.org/2.4/configuration.html#5.2-check-ssl) to the release.
I tested it working by hand originally on our staging and made a PR to replicate the setup with the bosh release. The Linter and test suite are green and without complaints. I also added a simple test for the property.